read receipts: handle implicit receipts for unread counts #3054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
implicit-read-receipts
branch
from
e6db7f2 to
b5667cd
Compare
bnjbvr
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
==========================================
+ Coverage 83.67% 83.68% +0.01%
==========================================
Files 222 222
Lines 23288 23304 +16
==========================================
+ Hits 19487 19503 +16
Misses 3801 3801 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients, including the timeline code handling the sending of read receipts, have the notion of an implicit read receipt. Every event that you've sent yourself implies that you've read all the events prior to yours. Both parts of the code should align on when to send read receipts, since computing unread counts precisely relies on read receipts echoed back by the server otherwise.
This patch adds a new method in the
ReceiptSelector, to look for an implicit read receipt and use it, if found and it's the latest in sync order.Also add lots of tracing
trace-level logs for making remote debugging easier.